Skip to content

feat: Add Python Virtual Environment Support: Add k8s Gateway Configuration#5138

Merged
kunwp1 merged 20 commits into
apache:mainfrom
SarahAsad23:pve-deployment
May 28, 2026
Merged

feat: Add Python Virtual Environment Support: Add k8s Gateway Configuration#5138
kunwp1 merged 20 commits into
apache:mainfrom
SarahAsad23:pve-deployment

Conversation

@SarahAsad23
Copy link
Copy Markdown
Contributor

@SarahAsad23 SarahAsad23 commented May 20, 2026 •
edited
Loading

What changes were proposed in this PR?

This PR is an extension of PR #4484, #4902, #5035, and #5069. It adds Kubernetes gateway routing and access control configurations.

Any related issues, documentation, discussions?

This change is part of ongoing efforts to support environment isolation and reproducibility within Texera. Related issue includes #4296. This PR closes sub-issue #5137.

How was this PR tested?

Tested manually and test added to AccessControlResourceSpec.

Was this PR authored or co-authored using generative AI tooling?

Co-authored using: Claude Code (claude-opus-4-7)

@SarahAsad23 SarahAsad23 marked this pull request as draft May 20, 2026 16:58
@github-actions github-actions Bot added engine frontend Changes related to the frontend GUI dev platform Non-amber Scala service paths labels May 20, 2026
@SarahAsad23 SarahAsad23 changed the title feat: Add Python Virtual Environment Support: Add K8s Gateway Configuration feat: Add Python Virtual Environment Support: Add k8s Gateway Configuration May 20, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.10%. Comparing base (85c4b0c) to head (54337af).

Files with missing lines Patch % Lines
...virtual-environment/virtual-environment.service.ts 0.00% 3 Missing ⚠️
...exera/service/resource/AccessControlResource.scala 77.77% 0 Missing and 2 partials ⚠️
...esource/pythonvirtualenvironment/PveResource.scala 0.00% 2 Missing ⚠️
...ythonvirtualenvironment/PveWebsocketResource.scala 0.00% 1 Missing ⚠️
...power-button/computing-unit-selection.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5138      +/-   ##
============================================
+ Coverage     49.09%   49.10%   +0.01%     
- Complexity     2372     2373       +1     
============================================
  Files          1051     1051              
  Lines         40344    40348       +4     
  Branches       4277     4279       +2     
============================================
+ Hits          19805    19814       +9     
+ Misses        19379    19371       -8     
- Partials       1160     1163       +3
Flag Coverage Δ *Carryforward flag
access-control-service 41.89% <77.77%> (+2.36%) ⬆️
agent-service 33.76% <ø> (ø) Carriedforward from ca829ec
amber 51.52% <0.00%> (-0.01%) ⬇️
computing-unit-managing-service 0.00% <ø> (ø)
config-service 0.00% <ø> (ø)
file-service 37.99% <ø> (ø)
frontend 41.07% <0.00%> (+<0.01%) ⬆️
python 90.79% <ø> (+0.04%) ⬆️ Carriedforward from ca829ec
workflow-compiling-service 56.81% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SarahAsad23 SarahAsad23 marked this pull request as ready for review May 22, 2026 07:57
@kunwp1 kunwp1 self-requested a review May 24, 2026 02:50
@kunwp1 kunwp1 linked an issue May 24, 2026 that may be closed by this pull request
Add Python Virtual Environment K8s Gateway Configuration #5137
Closed
6 tasks
kunwp1
kunwp1 requested changes May 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kunwp1 kunwp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Left some comments.

Comment thread amber/src/main/scala/org/apache/texera/web/resource/pythonvirtualenvironment/PveResource.scala Outdated
Comment thread ...ontrol-service/src/main/scala/org/apache/texera/service/resource/AccessControlResource.scala Outdated
Comment thread ...ontrol-service/src/main/scala/org/apache/texera/service/resource/AccessControlResource.scala
@SarahAsad23 SarahAsad23 requested a review from kunwp1 May 28, 2026 20:53
kunwp1
kunwp1 approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kunwp1 kunwp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Before merging this PR can you also address the codecov report to increase the coverage?

@SarahAsad23
Copy link
Copy Markdown
Contributor Author

SarahAsad23 commented May 28, 2026

I checked the Codecov report, and the AccessControlResource changes are already covered by the tests added in AccessControlResourceSpec. The remaining missing lines are in the PVE related resource/service files and the computing unit selection component, but those are already covered by the PythonVirtualEnvironmentResourceSpec added in a previous PR.

@kunwp1 kunwp1 added this pull request to the merge queue May 28, 2026
Merged via the queue into apache:main with commit ec12c88 May 28, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kunwp1 kunwp1 kunwp1 approved these changes

Assignees

@SarahAsad23 SarahAsad23

Labels

dev engine frontend Changes related to the frontend GUI platform Non-amber Scala service paths

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Python Virtual Environment K8s Gateway Configuration

3 participants

@SarahAsad23 @codecov-commenter @kunwp1